Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: very nitty Update dnsdist-lua-actions.cc #14681

Merged
merged 1 commit into from
Sep 18, 2024
Merged

dnsdist: very nitty Update dnsdist-lua-actions.cc #14681

merged 1 commit into from
Sep 18, 2024

Conversation

phonedph1
Copy link
Contributor

Short description

cannot unsee the extra space, it has haunted me for days now

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10911668148

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 32 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-1.6%) to 64.682%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/dnsdistdist/dnsdist-lua-actions.cc 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pdns/packethandler.cc 1 72.82%
pdns/recursordist/sortlist.cc 2 74.12%
pdns/recursordist/negcache.hh 2 88.24%
pdns/opensslsigners.cc 2 61.13%
pdns/ws-auth.cc 2 80.8%
pdns/recursordist/test-syncres_cc2.cc 3 88.91%
pdns/tsigverifier.cc 3 77.22%
modules/gpgsqlbackend/spgsql.cc 3 67.94%
pdns/recursordist/rec-system-resolve.cc 14 43.87%
Totals Coverage Status
Change from base Build 10905401638: -1.6%
Covered Lines: 124791
Relevant Lines: 162218
💛 - Coveralls

rgacogne
rgacogne approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@rgacogne rgacogne merged commit 0171b03 into PowerDNS:master Sep 18, 2024
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgacogne rgacogne rgacogne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phonedph1 @coveralls @rgacogne